Re: [LAU] yet another yoshimi bug fix, -> 0.022

cal wrote:
> Peter Nelson wrote:
>> [ ... ]
>> Another issue I've found is that the pitch-bend controller is offset by
>> some pitch. Sending a pitch bend of 0 results in a pitch one whole-note
>> higher than it should be.
>
> You're right - not good.

One bit too far ...
--- yoshimi-dev.orig/src/MusicIO/JackEngine.cpp
+++ yoshimi-dev/src/MusicIO/JackEngine.cpp
@@ -478,7 +478,7 @@
 
             case 0xE0: // pitch bend
                 ctrltype = C_pitchwheel;
- par = ((midi.data[2] << 8) | midi.data[1]) - 8192;
+ par = ((midi.data[2] << 7) | midi.data[1]) - 8192;
                 setMidiController(channel, ctrltype, par);
                 break;
 
Looking back over the last two weeks I really shouldn't have been attempting
code changes, and I certainly shouldn't have been posting the results. People
have been remarkably tolerant, and for that I very grateful.

cheers.

_______________________________________________
Linux-audio-user mailing list
Linux-audio-user@email-addr-hidden
http://lists.linuxaudio.org/mailman/listinfo/linux-audio-user
Received on Wed Oct 14 04:15:04 2009