Subject: Re: [linux-audio-dev] [PATCH] oss driver for jack 0.90.0 - the actual patch :)
From: Jussi Laako (jussi.laako_AT_pp.inet.fi)
Date: Tue Nov 18 2003 - 22:28:37 EET
On Mon, 2003-11-17 at 04:07, Paul Davis wrote:
Thanks for pointing out the errors in code.
> 1) the null cycle callback is wrong. it will generate random noise, and
> should instead generate silence.
OK, fixed...
> 2) the buffer size callback is wrong. you have to stop the hardware,
> reset the period size, and then restart the hardware.
OK, fixed too. Maybe the documentation in driver.h is either incorrect
or misleading or I just understood it wrong.. :)
> 3) is there a reason why you are not using bob's infrastructure for
> APIs without their own thread? it seems wasteful to duplicate
> this again. the OSS driver should be like the ALSA one in this
> respect.
Because of how the newest version of driver is implemented.
> joq is correct that adding a new driver adds a real burden to the
> core JACK team. if you are unwilling to commit to maintaining the
> driver to keep track with other JACK changes, then we should not add
> it to CVS.
It's of course your decision.. However, will it be included or not, I
will continue developing the driver for unspecified amount of time. At
least as long as I have interest, time and there are some interested
users out there... :)
-- Jussi Laako <jussi.laako_AT_pp.inet.fi>
This archive was generated by hypermail 2b28 : Tue Nov 18 2003 - 22:27:04 EET