Subject: [linux-audio-dev] mini Review: Re: [Jackit-devel] latest CVS commit
From: Roger Larsson (roger.larsson_AT_norran.net)
Date: Tue Dec 02 2003 - 03:07:25 EET
On Monday 01 December 2003 20.48, Paul Davis wrote:
> i'd appreciate test reports ASAP, so that out trusty release
> technician (the very wonderful taybin rutkin) can get a new release
> out in the near future.
>
alsa_driver.c
driver->period_usecs =
(jack_time_t) floor ((((float) driver->frames_per_cycle) /
driver->frame_rate) * 1000000.0f);
jackd/engine.c
poll_timeout = (engine->control->real_time == 0 ?
engine->client_timeout_msecs :
engine->driver->period_usecs/1000);
- - -
if (poll (pfd, 1, poll_timeout) < 0) {
Isn't this dangerous?
* What happens if period_usecs < 1000?
Well poll_timeout gets 0 since period_usecs is an uint64_t
A poll with time out of zero will return immediately.
OK?
/RogerL
-- Roger Larsson Skellefteċ Sweden
This archive was generated by hypermail 2b28 : Tue Dec 02 2003 - 03:15:47 EET