Re: [linux-audio-dev] ieee1394 deadlock on RT kernels

On Mon, 2006-06-26 at 21:44 +0200, Pieter Palmers wrote:
> Lee Revell wrote:
> > On Mon, 2006-06-26 at 21:05 +0200, Pieter Palmers wrote:
> >> Lee Revell wrote:
> >>> On Mon, 2006-06-26 at 16:51 +0200, Pieter Palmers wrote:
> >>>>
> >>>> Of course. My monday-morning bad temper is over by now, and I hope I
> >>>> didn't transfer it to any of you. I'll provide the panic, one way or
> >>>> another.
> >>>>
> >>> Can you reproduce the problem on a non-RT kernel?
> >>>
> >> No, it only occurs with RT kernels, and only with those configured for
> >> PREEMPT_RT. If I use PREEMPT_DESKTOP, there is no problem. (with
> >> threaded IRQ's etc... only switched over the preemption level in the
> >> kernel config).
> >>
> >> I've uploaded the photo's of the panic here:
> >> http://freebob.sourceforge.net/old/img_3378.jpg (without flash)
> >> http://freebob.sourceforge.net/old/img_3377.jpg (with flash)
> >>
> >> both are of suboptimal quality unfortunately, but all info is readable
> >> on one or the other.
> >
> > Can you add debug printk's before and after tasklet_kill() in
> > ohci1394_unregister_iso_tasklet to see where it locks up?
> >
> That's the first thing I did: the printk before tasklet_kill succeeds,
> the one right after the tasklet_kill doesn't.

Actually the problem might not be the change to tasklet_kill() but the
change to tasklet_unlock_wait().

include/linux/interrupt.h:

#if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT)
static inline void tasklet_unlock_wait(struct tasklet_struct *t)
{
        while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { barrier(); }
}
#else
# define tasklet_unlock_wait(t) do { } while (0)

Can you add a printk before that while loop?

Lee
Received on Tue Jun 27 00:15:03 2006