Re: [LAD] [Jackit-devel] [PATCH] jack dbus and logs improvement

From: Krzysztof Foltman <wdev@email-addr-hidden>
Date: Tue Dec 18 2007 - 16:44:16 EET

Nedko Arnaudov wrote:

> I'd like to hear what other ppl think about this. It works for me both
> ways. If most ppl like to have two modes merged in one executable just
> to see jackd is running not jackdbus, so be it, I'll merge those changes
> into dbus patch.

I'm definitely in favour of the merge. The previous solution (old jackd,
 new jackdbus) was definitely confusing to me. While I understand the
distinction now, it wasn't obvious at first.

>> Also fixed quite a few warnings and doxygen errors.
> Having those as separate patches for review and commit in trunk would be
> great.

Agreed. Mixing several unrelated fixes in one patch is just wrong.
Having multiple patches to apply in order to test the dbus version is
inconvenient.

I guess things like doxygen comment fixes can be safely committed in
trunk without risking severe regressions, so why not do it? :) :) :)

>> Remote controllable jackd is nice, but first thing's first: It would
>> REALLY be nice to have nedko's jackd-midi-alsa-munge and jack-logs
>> patches applied to trunk to kill the intolerably awful midi port naming
>> problem and shrink the size of this behemoth patch. Both are
>> straightforward, fix things that need fixing, and break nothing.
>> PLEASE? :)
> PLEASE? :)

PLEASE? :)

(ok, maybe I should read those patches first!)

>> Attached patch is against most recent SVN, R1070
> It is not usable directly. At least it misses some files introduced by
> the dbus patch:
> jackd.c:43:22: error: jackdbus.h: No such file or directory

Can't check it now (still at work).

Krzysztof

_______________________________________________
Linux-audio-dev mailing list
Linux-audio-dev@email-addr-hidden
http://lists.linuxaudio.org/mailman/listinfo/linux-audio-dev
Received on Wed Dec 19 00:15:39 2007

This archive was generated by hypermail 2.1.8 : Wed Dec 19 2007 - 00:15:39 EET