Re: [LAD] libsoundio 1.0.0 released today

From: Andrew Kelley <superjoe30@email-addr-hidden>
Date: Fri Sep 04 2015 - 21:12:57 EEST

On Fri, Sep 4, 2015 at 11:01 AM Devin Anderson <surfacepatterns@email-addr-hidden>
wrote:

> On Thu, Sep 3, 2015 at 12:41 PM, Andrew Kelley <superjoe30@email-addr-hidden>
> wrote:
>
> I'm not going to download and play with it because I have no need for
> it currently, but I did take a look at some of the code. It's
> meticulously clean. Quite readable. Thanks for taking the time to
> make it that way.
>

Thanks for the compliment.

> In my quick read through some of the code, I noticed a duplicate
> assertion on line 756 of alsa.cpp:
>
> assert(errno != EFAULT);
>

Thanks for pointing this out. Fixed in f8cb816
<https://github.com/andrewrk/libsoundio/commit/f8cb816139ce1635169488bba6344c63824c579f>.
I double checked the poll man page and it was indeed just a duplicate.

_______________________________________________
Linux-audio-dev mailing list
Linux-audio-dev@email-addr-hidden
http://lists.linuxaudio.org/listinfo/linux-audio-dev
Received on Sat Sep 5 00:15:02 2015

This archive was generated by hypermail 2.1.8 : Sat Sep 05 2015 - 00:15:02 EEST